Repository navigation
fix(web): restore effort picker keyboard typeahead - #40798
Conversation
Drop the picker-level integration test: a matching letter stops at the column, so the column test already fails on main for this bug. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
In the composer's model picker, the reasoning-effort column answered only to the arrow keys, so typing a level's first letter no longer jumped to it (#31371). With a level focused, typing a letter now moves focus to the next level whose label starts with it, wrapping round to the top, without changing the selection. Modified keys (Ctrl, Alt, Meta), Space and input-method composition are left alone.
Fixes #31371
Supersedes #31400. The change is @shadowfeind's; their commits are kept.
Reproduction on main
In the macOS desktop app, open a thread using a model with Low, Medium, and High effort levels and select Medium. Press Cmd+Shift+E, then type l: main leaves Medium focused, whereas this change focuses Low while Medium remains selected. Press Enter to select Low. With Minimal, Medium, and Max available, repeated m should cycle through matching enabled levels.
Evidence
Real web app, Chromium, 1280×800, light theme, fresh synthetic data on each commit. Open the effort picker with Control+Shift+E, wait for Medium focus, and type
l. Base leaves Medium focused; head focuses Low while Medium stays checked. On head, Enter selects Low, and repeatedmcycles Medium → Max → Minimal without changing selection.Scenario and synthetic agent source.
Not shown:
Tests
vp test run src/components/chat/ComposerModelEffort.browser.test.tsx(apps/web): 2 passedComposerModelEffort.tsxswapped in: the typeahead test fails, as expectedvp run check:changed: format, lint, knip, typecheck (2 packages), tests and React compiler all passNot in this change
Who did the work
Run by the t3code factory in T3 Code.