Skip to content

fix(web): restore effort picker keyboard typeahead - #40798

Merged
juliusmarminge merged 3 commits into
mainfrom
factory/pr-31400-a1795343501
Nov 22, 2026
Merged

juliusmarminge merged 3 commits into
mainfrom
factory/pr-31400-a1795343501

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Nov 22, 2026 •

Copy link
Copy Markdown
Member

In the composer's model picker, the reasoning-effort column answered only to the arrow keys, so typing a level's first letter no longer jumped to it (#31371). With a level focused, typing a letter now moves focus to the next level whose label starts with it, wrapping round to the top, without changing the selection. Modified keys (Ctrl, Alt, Meta), Space and input-method composition are left alone.

Fixes #31371

Supersedes #31400. The change is @shadowfeind's; their commits are kept.

Reproduction on main

In the macOS desktop app, open a thread using a model with Low, Medium, and High effort levels and select Medium. Press Cmd+Shift+E, then type l: main leaves Medium focused, whereas this change focuses Low while Medium remains selected. Press Enter to select Low. With Minimal, Medium, and Max available, repeated m should cycle through matching enabled levels.

Evidence

Real web app, Chromium, 1280×800, light theme, fresh synthetic data on each commit. Open the effort picker with Control+Shift+E, wait for Medium focus, and type l. Base leaves Medium focused; head focuses Low while Medium stays checked. On head, Enter selects Low, and repeated m cycles Medium → Max → Minimal without changing selection.

Before After
Commit c198f73b37 4b62b1f572
After typing l Before: Medium remains focused and selected After: Low focused, Medium selected
Enter selects Low After: Enter selects Low
First m After: Medium focused, Low selected
Second m After: Max focused, Low selected
Third m wraps After: Minimal focused, Low selected
Recording Before keyboard interaction After keyboard interaction

Scenario and synthetic agent source.

Not shown:

  • The macOS desktop shell and Cmd shortcut were not exercised; the shared web picker was verified on Linux Chromium using Control+Shift+E.
  • Uppercase matching and disabled-level skipping were not separately exercised; all synthetic effort levels were enabled.

Tests

  • vp test run src/components/chat/ComposerModelEffort.browser.test.tsx (apps/web): 2 passed
  • Same test with main's ComposerModelEffort.tsx swapped in: the typeahead test fails, as expected
  • vp run check:changed: format, lint, knip, typecheck (2 packages), tests and React compiler all pass
  • CI on 4b62b1f: all 38 checks passed

Not in this change

  • Letter typeahead targets reasoning levels only, not the column's option rows (session mode, speed, toggles), as the author built it.

Who did the work

  • Written by Claude Opus 5.5, in Claude Code
  • Reviewed by GPT-6.1 Sol, in Codex, and by Claude Opus 5.5, each on its own
  • Proof captured by GPT-6.1 Sol and checked by Claude Opus 5.5

Run by the t3code factory in T3 Code.

shadowfeind and others added 3 commits November 5, 2026 16:03
Drop the picker-level integration test: a matching letter stops at the
column, so the column test already fails on main for this bug.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:trusted Author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Nov 22, 2026
@coderabbitai

coderabbitai Bot commented Nov 22, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The effort picker now moves focus to an enabled level whose label starts with a typed, unmodified character. Arrow-key navigation remains available. The browser test covers matching, wraparound, ignored keys, and selection with Enter.

Changes: Effort picker typeahead

Layer / File(s) Summary
Effort level typeahead
apps/web/src/components/chat/ComposerModelEffort.tsx, apps/web/src/components/chat/ComposerModelEffort.browser.test.tsx
Effort rows expose their labels for prefix matching. Typing a non-whitespace character without modifiers moves focus cyclically to a matching enabled row. Arrow-key navigation remains clamped. The browser test checks case-insensitive matching, wraparound, ignored modified keys and Delete, and selection with Enter.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Medium

Possibly related PRs

  • pingdotgg/t3code#29418: Restores letter navigation in the effort picker by matching typed letters against enabled row labels.
  • pingdotgg/t3code#31400: Adds first-letter navigation to effort picker rows, with wraparound and selection left to Enter.

Suggested reviewers: maria-rcks, macroscopeapp

Merge Risk: Minimal · up to 4b62b

This restores letter-based navigation in the effort picker and leaves arrow-key navigation unchanged. No concrete merge-blocking risk is evident, and it is easy to revert.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "fix(web): restore effort picker keyboard typeahead" names the main change: the composer's reasoning-effort picker regains first-letter typeahead. It follows conventional commit form and is …
Linked Issues check Passed Issue #31371 requires that typing an effort level's first letter moves focus to the next matching level, wraps to the top, cycles shared initials, matches on the level label, and leaves selection unch…
Out of Scope Changes check Passed All changed code serves the #31371 objective. The ColumnRow change in ComposerModelEffort.tsx changes only the value of data-effort-level and adds a comment. Existing selectors for that attribute stil…
Description check Passed The description covers the problem, the change, scope, and verification in detail. It links the issue (#31371), explains the reproduction on main, gives before/after evidence, and lists the tests run …
Full details: Title check

Explanation

The title "fix(web): restore effort picker keyboard typeahead" names the main change: the composer's reasoning-effort picker regains first-letter typeahead. It follows conventional commit form and is specific. The change also covers wrapping, modified-key handling, and the data-effort-level attribute, but the title does not need to list them.

Full details: Linked Issues check

Explanation

Issue #31371 requires that typing an effort level's first letter moves focus to the next matching level, wraps to the top, cycles shared initials, matches on the level label, and leaves selection unchanged until Enter. The diff to ComposerModelEffort.tsx at the reviewed head covers these points. moveBetweenRows now handles single printable, non-whitespace keys. It searches the enabled [data-effort-row] buttons from the row after the focused one, wrapping back through the focused row. It compares the typed key with data-effort-level, which ColumnRow now sets to props.label, so matching uses the label and not the full textContent. The handler only moves focus and does not click, so selection stays unchanged. Enter behavior is unchanged. Repeated letters cycle because the search starts after the current row. The raw summary reports a browser test in ComposerModelEffort.browser.test.tsx that covers focus movement, wrapping, modifier keys, and Enter selection. I did not read that test file directly, so its results rely on the summary and the PR's reported test run. The #31371 requirements are met by the code evidence. The Evidence section of the PR description is non-coding and does not affect this result.

Full details: Out of Scope Changes check

Explanation

All changed code serves the #31371 objective. The ColumnRow change in ComposerModelEffort.tsx changes only the value of data-effort-level and adds a comment. Existing selectors for that attribute still match. The moveBetweenRows change adds the typeahead branch. It also keeps the arrow-key behavior and the existing guard for events from an option's side menu. The browser test in the raw summary checks the new behavior. The PR description states that typeahead does not extend to other option rows, and the code matches that limit. No unrelated change was identified in the diff or the summary.

Full details: Description check

Explanation

The description covers the problem, the change, scope, and verification in detail. It links the issue (#31371), explains the reproduction on main, gives before/after evidence, and lists the tests run and what was not exercised. It follows the template's section intent. The Problem, Change, Scope, and Verification content is present, and the attribution line matches the template request. Minor gaps: the Scope section does not restate why this is a bug fix rather than a feature, although the linked issue describes a regression. The description is mostly complete.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between c198f73 and 4b62b1f.

Files selected for processing: 2

  • apps/web/src/components/chat/ComposerModelEffort.browser.test.tsx
  • apps/web/src/components/chat/ComposerModelEffort.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 0 remain after this review.

@juliusmarminge
juliusmarminge merged commit 1acfd37 into main Nov 22, 2026
39 checks passed
@juliusmarminge
juliusmarminge deleted the factory/pr-31400-a1795343501 branch November 22, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted Author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Effort picker no longer jumps to a level when you type its first letter

2 participants